Last modified: 2011-03-13 17:38:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29634, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 27634 - TOC title appears in wrong language


Summary:	TOC title appears in wrong language

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://fr.wikipedia.org/wiki/Edward_W...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-02-22 14:16 UTC by P.Copp
Modified:	2011-03-13 17:38 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Proposed patch: Pass mParserOptions->getUserLang() to Linker::tocList() (1.19 KB, patch) 2011-02-22 14:16 UTC, P.Copp	Details
Add an attachment (proposed patch, testcase, etc.)

Description P.Copp 2011-02-22 14:16:36 UTC

Created attachment 8192 [details]
Proposed patch: Pass mParserOptions->getUserLang() to Linker::tocList()

Steps to reproduce:
* Log in
* Set your user language to sth. different than the content language.
* Make an edit to an article.
* Log out
* Note, that the toc title is shown in the language you have chosen above.

The parser cache gets corrupted, because Linker::tocList() uses wfMsgHtml for the toc title rather than using the language from ParserOptions.

The attached patch will fix the issue by adding a $lang parameter to Linker::tocList and using it from Parser::formatHeadings(). Note, that for trunk this will reintroduce the parser cache fragmentation, that has been tried to avoid by r79520 and follow-ups.

Comment 1 Mark A. Hershberger 2011-02-23 20:35:26 UTC

Applied in r82696.

Comment 2 Mark A. Hershberger 2011-02-23 20:36:59 UTC

Marking resolved, but noting parser cache problems in CR comments.

Comment 3 Mark A. Hershberger 2011-02-23 20:46:19 UTC

reopening since it hasn't been deployed yet.  Need to remove deployment blocker or deploy to close.

Comment 4 Platonides 2011-02-25 00:24:44 UTC

Thanks for your patch, Paul. :)

Mah: it is only reintroduced for trunk. This is no blocker for deployment.

Comment 5 Mark A. Hershberger 2011-03-13 17:38:10 UTC

Re-closing per comment #4

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links