Last modified: 2011-12-19 18:39:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29611, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27611 - list=blocks: Use ipb_by_text instead of join with user table
list=blocks: Use ipb_by_text instead of join with user table
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on: 27613
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-21 17:40 UTC by db [inactive,noenotif]
Modified: 2011-12-19 18:39 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2011-02-21 17:40:26 UTC 
The database field ipb_by_text of the table ipblocks is unused by the api.

The api makes a join with the user table. Looks like old code, because ipb_by_text was added in 1.13, maybe update for better performance?
Comment 1 Sam Reed (reedy) 2011-02-21 19:35:19 UTC 
Nice catch. The only downside I can see to this, is we then get "old" names, as the block logs aren't renamed.

ie on en.wiki, I was "Reedy Boy", but now I'm "Reedy".

Not so much of a big deal IMHO


Thanks! r82568
Comment 2 db [inactive,noenotif] 2011-02-21 21:00:08 UTC 
(In reply to comment #1)
> The only downside I can see to this, is we then get "old" names, as
> the block logs aren't renamed.

Looks like bug 23135
Comment 3 Sam Reed (reedy) 2011-02-21 21:25:12 UTC 
Aye, not a big deal, and would need a cleanup maintenance script
Comment 4 db [inactive,noenotif] 2011-12-19 18:39:58 UTC 
Maybe needs a revert, see bug 31863
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links