Last modified: 2011-03-22 00:11:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29586, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27586 - Remove duplication of props in ApiQueryStashImageInfo by using ApiQueryImageInfo
Remove duplication of props in ApiQueryStashImageInfo by using ApiQueryImageInfo
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on: 27589
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-20 13:53 UTC by Sam Reed (reedy)
Modified: 2011-03-22 00:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Describing above (1.98 KB, patch)
2011-02-20 13:53 UTC, Sam Reed (reedy) 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-02-20 13:53:39 UTC 
Created attachment 8180 [details]
Describing above

More a question for Bryan than anything...

Can everything that is done on a normal image be done on a Stashed Image?

I'm wanting to remove the duplication of the properties code. See patch.

If not, what can't be done, as I want to look at doing it a bit more programatically than having all that duplication (array_diff or similar probably)
Comment 1 Bryan Tong Minh 2011-02-20 19:01:20 UTC 
Stashed images don't have a comment, and possibly no user, but would need to check that. Also archivename is not applicable.
Comment 2 Bryan Tong Minh 2011-02-20 19:46:50 UTC 
Since you're working on this, I'm marking bug 27589 depending on this one, as it uses getPropertyNames() as well.
Comment 3 Sam Reed (reedy) 2011-03-22 00:11:01 UTC 
r84504 does this one :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links