Last modified: 2011-02-25 10:33:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 27530 - Recent revision is not flagged after rollback to a good version
Recent revision is not flagged after rollback to a good version
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Rob Lanphier
http://ru.wikipedia.org/w/index.php?t...
:
Depends on: 14074
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-18 12:42 UTC by Innocenti Maresin
Modified: 2011-02-25 10:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Innocenti Maresin 2011-02-18 12:42:35 UTC
Automatic flagging after rollback, as implemented by [[bugzilla:14074]], appears to be broken now. At least, history http://ru.wikipedia.org/w/index.php?title=Nokia_5230&offset=20110218111400&limit=3&curid=2041269&action=history&uselang=en and diffs show that the new good revision is not flagged.

The review log http://ru.wikipedia.org/w/index.php?title=Special:Log&type=review&user=&page=Nokia+5230&uselang=en shows that it was the old good revision reviewed in the time of rolling back, nothing about the recent one.
Comment 1 Innocenti Maresin 2011-02-18 13:08:43 UTC
Although 14074 marked as WONTFIX in this database, automatic rollback flagging actually worked in the past (2009–2010, say, before MW 1.17). This history http://ru.wikipedia.org/w/index.php?title=Trine&offset=20101229999999&limit=4&action=history&uselang=en clearly demonstrates the recent revision was "automatically checked".
Comment 2 Aaron Schulz 2011-02-18 22:04:15 UTC
Any other cases? I can't repro this yet on my test wiki.
Comment 3 Aaron Schulz 2011-02-18 22:15:21 UTC
Was this actually software rollback (via [rollback]) or some JS script based rollback?
Comment 4 Innocenti Maresin 2011-02-19 15:20:47 UTC
We can not perform other cases, not by Yakiv_Gluck nor by other users.
I think that it was the 1.17 deployment what resulted in [[w:ru:Nokia_5230]] anomaly. An old good revision was stored before it, and vandalism and rollbacking occurred after it. So, this is probably a deployment bug, not a FlaggedRevs bug.

Ordinary action=rollback was used: http://ru.wikipedia.org/w/index.php?title=…&action=rollback&from=…&token=…%2B%5C

Thanks
Comment 5 Aaron Schulz 2011-02-20 11:02:57 UTC
I'll let this sit a few days before closing. I can't see why this would happen.
Comment 6 Aaron Schulz 2011-02-25 10:33:03 UTC
(In reply to comment #4)
> We can not perform other cases, not by Yakiv_Gluck nor by other users.
> I think that it was the 1.17 deployment what resulted in [[w:ru:Nokia_5230]]
> anomaly.

Assuming this as a deployment anomaly. I can't see any likely race problems in maybeMakeEditReviewed() or autoReviewEdit() either.

Closing WMF (though that isn't the most exact status since there is an example).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links