Last modified: 2011-03-17 22:32:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29505, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27505 - Rejecting a change by an IP puts link to IP userpage in default summary, not xyr contribs as expected
Rejecting a change by an IP puts link to IP userpage in default summary, not ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikinews.org/w/index.php?ti...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-17 19:38 UTC by Douglas Gardner
Modified: 2011-03-17 22:32 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Douglas Gardner 2011-02-17 19:38:07 UTC
On enwikinews, rejecting an edit on a sighted article gives the following default edit summary:

Rejected the last change (by [[User:127.0.0.1|127.0.0.1]]) and restored revision 12345678 by Username

As IPs don't generally have userpages, FlaggedRevs should follow the convention of linking to IP talk pages:

Rejected the last change (by [[Special:Contributions/127.0.0.1|127.0.0.1]]) and restored revision 12345678 by Username

Example diff:
http://en.wikinews.org/w/index.php?title=Former_Egyptian_president_Mubarak_reportedly_ill,_may_be_in_coma&curid=245306&diff=1180742&oldid=1180738

As of this post, enwikinews has FlaggedRevisions r82223, and MediaWiki version 1.17wmf1.
Comment 1 Aaron Schulz 2011-02-17 22:06:43 UTC
This is partly done to save space (due to the annoying 255 char summary limit).
Comment 2 Rob Lanphier 2011-02-17 22:31:48 UTC
We could possibly use [[User:127.0.0.1]] as a compromise.
Comment 3 Aaron Schulz 2011-02-17 22:34:02 UTC
Wait, do you want the link to go to the user talk page or the contributions page?
Comment 4 Aaron Schulz 2011-02-17 22:40:11 UTC
(In reply to comment #2)
> We could possibly use [[User:127.0.0.1]] as a compromise.

I assume you mean "User talk" :)
Comment 5 Mark A. Hershberger 2011-02-17 22:42:47 UTC
Looking at the page, I think he wants Special:Contributions.  The left column of the link has Special:Contributions (and a blue link), the right column has User: (and a red link).
Comment 6 Douglas Gardner 2011-02-18 13:12:55 UTC
It's just that rollback, ~~~, etc appears to link to Special:Contributions for logged-out users, which makes sense, considering IP userpages are exceedingly rare.

As far as I can tell, $wgMaxNameChars has a default value of 255, which would break the edit summary anyway. Adding [[Special:Contributions/XXX.XXX.XXX.XXX|XXX.XXX.XXX.XXX]] still leaves 136 characters for the other username, which is more than ample, surely, for most usernames?

For comparision, the following is 136 characters long:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean nec tortor massa. Nulla quis ultricies leo. Nunc rhoncus mi in orci sed.

The following is 153 characters long:
Cras bibendum erat in risus sagittis interdum. Duis eget placerat dui. Sed rutrum laoreet neque et dictum. Curabitur mauris sem, aliquam posuere posuere.

How many usernames are four sentences long?

As an aside, according to the relase notes, 1.18 has [[Special:Contribs]] as a redir to [[Special:Contributions]].
Comment 7 Douglas Gardner 2011-02-18 13:48:20 UTC
By the way, it's r79795 for the Contribs -> Contributions thing.
Comment 8 Aaron Schulz 2011-02-18 15:53:58 UTC
This has nothing to do with maxnamechars, but with the total summary length, bug 4715.
Comment 9 Aaron Schulz 2011-02-18 15:59:11 UTC
(In reply to comment #8)
> This has nothing to do with maxnamechars, but with the total summary length,
> bug 4715.

Well maybe in terms of pathological usernames. But the main problem is reverting 3-4 users at once, especially in multibyte heavy languages in unicode (cutting the effective length in half in cases). Links like [[User:X|X]] are already more than double the size of X.
Comment 10 Aaron Schulz 2011-02-26 03:19:39 UTC
(In reply to comment #7)
> By the way, it's r79795 for the Contribs -> Contributions thing.

I'll wait for that to be reviewed.
Comment 11 Aaron Schulz 2011-03-17 22:32:03 UTC
Done in r84211.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links