Last modified: 2011-02-16 23:38:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 27479 - API error when using both prop=pageprops and prop=info&inprop=displaytitle
API error when using both prop=pageprops and prop=info&inprop=displaytitle
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Roan Kattouw
http://en.wikipedia.org/w/api.php?for...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-16 23:25 UTC by Brad Jorsch
Modified: 2011-02-16 23:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Mentioned patch (591 bytes, patch)
2011-02-16 23:25 UTC, Brad Jorsch
Details

Description Brad Jorsch 2011-02-16 23:25:57 UTC
Created attachment 8155 [details]
Mentioned patch

Quite simply, both prop=pageprops and prop=info&inprop=displaytitle try to set "displaytitle" on the returned node: internal_api_error_MWException" info="Exception Caught: Internal error in ApiResult::setElement: Attempting to merge element 25970423

Pageprops should probably have been made to store its values in a subnode, like prop=categoryinfo and basically everything else does to prevent this sort of naming conflict. For example,
      <page pageid="25970423" ns="0" title="IPad">
        <pageprops defaultsort="Ipad" displaytitle="iPad" />
      </page>

It's a really easy (but breaking) change to do that. I don't know what a good solution would be without introducing a breaking change, especially since it's possible similar conflicts could arise with other page props.
Comment 1 Sam Reed (reedy) 2011-02-16 23:32:58 UTC
Well, seeing as it errors... It therefore cannot have worked.. And therefore isn't really a breaking change...

Also replicable on trunk

Will commit patch
Comment 2 Sam Reed (reedy) 2011-02-16 23:34:31 UTC
r75282 at fault

So it's in the 1.17 release. So we can backport without hopefully breaking anything :)
Comment 3 Sam Reed (reedy) 2011-02-16 23:38:38 UTC
r82312

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links