Last modified: 2011-02-24 21:17:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 27458 - Remove white background-color from ul.gallery
Remove white background-color from ul.gallery
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Krinkle
http://commons.wikimedia.org/wiki/Fil...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-16 15:13 UTC by Raimond Spekking
Modified: 2011-02-24 21:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2011-02-16 15:13:50 UTC
Related to the fixes for Bug 3276.

<gallery> hat a white background now which looks weird, see URL for an example.
Comment 1 DieBuche 2011-02-16 15:49:19 UTC
Combined patch is attached at Bug:27338
Comment 2 Mark A. Hershberger 2011-02-16 23:13:19 UTC
Please see r26470 and http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/51785
Comment 3 Mark A. Hershberger 2011-02-16 23:20:23 UTC
Oops, meant bug #26470
Comment 4 Mark A. Hershberger 2011-02-17 00:19:36 UTC
shoulda just duped this when I commmented,

*** This bug has been marked as a duplicate of bug 26470 ***
Comment 5 Raimond Spekking 2011-02-17 07:35:47 UTC
This is not ad dupe. I do not speak about a checkered background.

ul.gallery is set to background:white which looks weird, please see http://commons.wikimedia.org/wiki/File:Haus_Neuerburg_K%C3%B6ln_-_Turm_%289699-9701%29.jpg section "other versions"
Comment 6 Mark A. Hershberger 2011-02-17 15:11:20 UTC
it is a dupe of that bug since that one gives users a preference of what they want.  Solid white background could be done.

Also, people trying to fix that bug caused your bug report.  You should make sure your voice is heard on that bug since it is the one that people are working on.

*** This bug has been marked as a duplicate of bug 26470 ***
Comment 7 DieBuche 2011-02-17 15:13:48 UTC
I'm sorry, but this is not a dupe.
This bug is about the background of the *whole* gallery, 
the other about the background of single pictures.

Please have a look at the screenshot: There's no transparent image in it.
Comment 8 Mark A. Hershberger 2011-02-17 15:15:35 UTC
What was the background before?
Comment 9 Mark A. Hershberger 2011-02-18 16:49:02 UTC
I've avoided re-duping this bug, but would like some feedback: You say look at the "Other Versions" row and I can see that this row does have a different background.

Is this (an example of) the problem this bug seeks to fix?
Comment 10 Raimond Spekking 2011-02-18 16:52:11 UTC
Yes. The background of [[Commons:Template:Information]] is a light blue. The *whole* gallery has a white background now, instead of transparent as before.
Comment 11 Krinkle 2011-02-18 17:18:28 UTC
This white background color is not new. It's been white since r54097:
r1=54096&r2=54097#l713">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?&pathrev=54097&r1=54096&r2=54097#l713

Since 1.17 they are UL's and the selector was changed to ul.gallery in r77411 :
r1=77410&r2=77411#l787">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?&pathrev=77411&r1=77410&r2=77411#l787

Commons specifically has had some javascript running that changed the layout of tables, this, as a side-effect, caused that core css not to apply because it changed the classes.

Now that the fluid functionality is in core, the core classes apply again (as they did on all other wikis anyways).

In the spirit of lines no longer going through tables, images and lists (bug 26449, solved in r79087 and r79091) ul.gallery's background may be dropped like-wise.

Changing summary as, again, this is not new in 1.17 at all.
Comment 12 Krinkle 2011-02-24 21:17:02 UTC
Fixed in r82748.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links