Last modified: 2014-04-17 15:33:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29431, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27431 - Drop legacy installer script from CheckUser extension (update.php hooks should already exist)
Drop legacy installer script from CheckUser extension (update.php hooks shoul...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CheckUser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 32456 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-15 14:56 UTC by Sam Reed (reedy)
Modified: 2014-04-17 15:33 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-02-15 14:56:11 UTC
Do we really need to reinvent the wheel?

Thought not.
Comment 1 AGK 2011-10-31 23:58:14 UTC
Because two seconds on Terminal are easier than five minutes peering at your Database Manager Of Choice's query window. Nobody likes messing around with the db more than can be helped, hence the handy install script. What's the big deal?
Comment 2 Aaron Schulz 2011-10-31 23:59:18 UTC
I think the OP is referring to the fact that it could use the Updater classes (and log the update as completed) via update.php.
Comment 3 p858snake 2011-11-01 00:00:06 UTC
(In reply to comment #1)
> Because two seconds on Terminal are easier than five minutes peering at your
> Database Manager Of Choice's query window. Nobody likes messing around with the
> db more than can be helped, hence the handy install script. What's the big
> deal?

That has nothing to do with it... Reedy is talking about why its rolling its own method instead of using the defacto standard that uses the update.php magic.
Comment 4 Aaron Schulz 2011-11-01 00:02:19 UTC
At the time the script was written, I think update.php and friends sucked and didn't really support this stuff too well.
Comment 5 AGK 2011-11-01 00:02:57 UTC
(In reply to comment #3)
> (In reply to comment #1)
> > Because two seconds on Terminal are easier than five minutes peering at your
> > Database Manager Of Choice's query window. Nobody likes messing around with the
> > db more than can be helped, hence the handy install script. What's the big
> > deal?
> 
> That has nothing to do with it... Reedy is talking about why its rolling its
> own method instead of using the defacto standard that uses the update.php
> magic.

Ah, I misunderstood. I thought his gripe was with that the extension makes the db changes with a script, rather than posting the query stuff on the MWwiki extension page - for pasting into a query window. I know a lot of people who run their own sites don't have shell access and have to find workarounds.
Comment 6 Brion Vibber 2011-11-01 00:06:52 UTC
I've changed the summary to clarify that we probably want to kill off that installer script.

IIRC there *are* already updater hooks in which should take care of setup when maintenance/update.php is run.

Should check to confirm there's nothing else that installer does that's necessary and go ahead and drop it out and update documentation to indicate using the regular updater channels.
Comment 7 Jesús Martínez Novo (Ciencia Al Poder) 2014-04-17 15:33:43 UTC
*** Bug 32456 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links