Last modified: 2010-05-15 15:38:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4742, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2742 - [Enotif] Strange email notification when someone made no changes.
[Enotif] Strange email notification when someone made no changes.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikipedia.org/wiki/Enotif
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-07 16:02 UTC by Stas Fomin
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Stas Fomin 2005-07-07 16:02:48 UTC
We use MediaWiki 1.4.5 + Enotif 2.0.0, but I think the problem remains ( I look
though CVS 1.5 codes).

Consider the following scenario:
1. We have non-empty article "TheArticle".
2. Alice watched "TheArticle".
3. Bob opens "TheArticle" for editing, set "watch this page" checkbox, made no
changes, but press "Save article" button.
4. Alice receive notification like "Bob edited TheArticle. _This is new page_". 
5. Alice fear that Bob "clear or recreate"  "TheArticle".

I think the problem is UserMailer.php/composeCommonMailtext:
in lines:  (lastest UserMailer.php from CVS contains similar lines...)

    if ($article->mOldid) {
        $body = str_replace('$NEWPAGE', wfMsg(
'email_notification_lastvisitedrevisiontext' ), $body);
        .....
    } else {
        $body = str_replace('$NEWPAGE', wfMsg( 'email_notification_newpagetext'
), $body );
        .....
    }

that is if "oldid" is not set, the software sends notification about "New page".
But "oldid" is not set the no changes made also...
Comment 1 T. Gries 2005-07-07 18:24:22 UTC
This is fully fixed -- but only in my special edition "EnotifWiki", see
http://meta.wikipedia.org/wiki/Enotif and
http://sourceforge.net/projects/enotifwiki.

The developers of MediaWiki did not yet commit all of my changes

If you want, please try my version EnotifWiki for MediaWiki 1.5beta2. This
evening (UTC) I will upload EnotifWiki for MediaWiki 1.5beta3 version.
Please monitor the sourceforge releases.
Comment 2 Stas Fomin 2005-07-08 10:47:57 UTC
I think that the bug severity="minor", and I will be completely satisfied, I the
bug will be fixed with  Target Milestone=1.5. 
I just want to notify developers about this bug.
I should wait 1.5 release (I our company we use 3 installations of MediaWiki
"1.4.5+ENotif 2.0+our patches"), this bug is not so important for us to remerge
ENotif in MediaWiki again. 
Thank you for quick reply.
Comment 3 Brion Vibber 2005-12-08 01:49:11 UTC
Fixed by updates in HEAD.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links