Last modified: 2011-03-26 19:36:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29416, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27416 - CodeReview's diff-line background causes disappearing descenders
CodeReview's diff-line background causes disappearing descenders
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-14 22:13 UTC by Tim Starling
Modified: 2011-03-26 19:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Cropped screenshot (4.46 KB, image/png)
2011-02-14 22:13 UTC, Tim Starling 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2011-02-14 22:13:46 UTC 
Created attachment 8146 [details]
Cropped screenshot

Adding a green background to the <ins> tags in CodeReview makes the descenders disappear. See attached screenshot. 

I don't like it anyway, the contrast is too low.
Comment 1 Krinkle 2011-02-14 22:18:11 UTC 
I'll check this out later. For now I'll just note to self and others that the reason for the addition of the background was better detection of whitespace.

sometimes a line looked like:

- function fooBarThing( $here, $that = FOO_BAR, $somethingElse ) { 
+ function fooBarThing( $here, $that = FOO_BAR, $somethingElse ) {

Where one may look for several seconds to catch the difference wheares with a background you'd notice the former line has a space after the opening curly bracket.
Comment 2 Sam Reed (reedy) 2011-03-26 19:36:00 UTC 
Reverted r82064 in r84818, reopening bug 27375
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links