Last modified: 2011-03-05 21:06:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29400, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27400 - Manual revision association won't accept "rXXXXX"
Manual revision association won't accept "rXXXXX"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-14 15:53 UTC by Sam Reed (reedy)
Modified: 2011-03-05 21:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-02-14 15:53:43 UTC 
Just tried putting in rXXXXX rather than XXXXX, it refreshed, and did nothing

As we can have Special:Code/MediaWiki/XXXXX and Special:Code/MediaWiki/rXXXXX, might aswell allow the r there
Comment 1 Krinkle 2011-02-14 19:57:42 UTC 
And it should in general do error and success messages. If I add 'hello' it also just submits silently.
Comment 2 Sam Reed (reedy) 2011-02-15 15:11:01 UTC 
r82169 makes it accept rXXXXX

Do we need the success and error messages? Success seems slightly redundant, as the result is it appears...

For error.. We have a couple of types. Ones that are in the wrong format, ie not XXXXX or rXXXXX.

Then, if the revisions is in a correct format, but it hits either of

if ( $rev > $this->getId() ) {

or

if ( $rev < $this->getId() ) {



Do we really need that level of verbosity?
Comment 3 Sam Reed (reedy) 2011-03-04 23:54:49 UTC 
Pinging this again.

If no input, I'm gonna resolve as fixed :P
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links