Last modified: 2011-04-23 23:46:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29389, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27389 - Update sortable table script to latest version
Update sortable table script to latest version
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-14 00:11 UTC by Krinkle
Modified: 2011-04-23 23:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-02-14 00:11:50 UTC
The sortable table we have in wikibits.js is an old version of the script.
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/wikibits.js?view=markup#l517

We should:
* Check if we made any adjustments to it
** if so, do we still need them or are they fixed upstream in the mean time ?
* Check out the latest version to see if it broke anything (ie. if it still supports class="unsortable", and <th> as head in a <tr> and not require <thead>)
* Rewrite that new version [1] in an object so we can easily put it somewhere in /resources/ without conflicting with names of the legacy version in wikibits.js or otherwise polluting the global/window namespace.
* Do some testing to verify that existing tables work fine
* Remove the old script and the sortables_init-call from wikibits.js
* Load the new script by default and call the Init() of it


[1] http://yoast.com/articles/sortable-table/
Tags: window.ts tablesort sortable table wikitable
Comment 1 DieBuche 2011-02-20 13:59:55 UTC
No love for Bug 8028#c15 ? It cuts execution time by 6/7 for IE. If no thead is a prerequisite, could probably done as well.
Comment 2 Krinkle 2011-04-23 23:46:21 UTC
This bug is no longer valid as the script has been removed in favour of the jquery plugin.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links