Last modified: 2014-06-17 17:02:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29381, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27381 - Don't (un)expand headings on right click
Don't (un)expand headings on right click
Status: RESOLVED FIXED
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Trevor Parscal
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-13 18:44 UTC by The Evil IP address
Modified: 2014-06-17 17:02 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Simple patch, checking event.which (606 bytes, patch)
2011-02-13 18:44 UTC, The Evil IP address 		Details
Simple patch, checking event.which (702 bytes, patch)
2011-02-13 19:06 UTC, The Evil IP address 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description The Evil IP address 2011-02-13 18:44:44 UTC 
Created attachment 8138 [details]
Simple patch, checking event.which

I have recently noted that the headings of the navigation bar also collapse or uncollapse on right click. IMO this is sort of unexpected, because you usually press the right mouse button maybe to go back or forward in the history, inspect an element out of interest as I did, check out the source or similar, however you don't expect the page to change when doing so.

I have added a simple patch which would solve this problem. I'm not sure about the middle mouse button, because I have never used one, so I left it as is with this button.

This fix is done in an extension, but under the component "MediaWiki extensions", I couldn't find Vector, so I did it here. Feel free to move.
Comment 1 The Evil IP address 2011-02-13 19:06:31 UTC 
Created attachment 8139 [details]
Simple patch, checking event.which

Fixed path, since I only checked out the modules directory due to the tiny memory of my netbook.
Comment 2 Mark A. Hershberger 2011-02-14 19:15:06 UTC 
See r82125
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links