Last modified: 2012-04-05 19:50:08 UTC
Krinkle added this in common.css, It's probably nice and usable enough to do in the core of CR: .mw-codereview-diff ins { background: #DDFFDD; } .mw-codereview-diff del { background: #FFDDDD; }
This doesn't seem to make any difference on my brower, but on my phone it seems to do...
Oh, seen it locally. Duh, diffs get cached r82064
Reverted r82064 in r84818, reopening this, closing bug 27416
This can be re-done. With bug 29307 fixed, bug 27416 will not occur anymore when background styling is added. I've added it to MediaWiki.org earlier this month: http://www.mediawiki.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=408365
(In reply to comment #4) > This can be re-done. > > With bug 29307 fixed, bug 27416 will not occur anymore when background styling > is added. > I've added it to MediaWiki.org earlier this month: > > http://www.mediawiki.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=408365 So it was you :P I did notice it seemed to change back again, but wasn't overly sure why Is it those bits just need re-adding?
Not the exact bits (colors are slightly changed) but the bits in the linked diff on mediawiki.org [1]. Also this depends on r89697 which fixed bug 29307.
The latest changes in the extension (which, among other things, changed the diff presentation into a *cough* table), have made it impossible to highlight trailing whitespace because the parent elements of the text are no longer inline elements and styling their background has no effect.
(In reply to comment #7) > The latest changes in the extension (which, among other things, changed the > diff presentation into a *cough* table), have made it impossible to highlight > trailing whitespace because the parent elements of the text are no longer > inline elements and styling their background has no effect. The latest changes make the diffs look like crap, IMHO.
(In reply to comment #8) > (In reply to comment #7) > > The latest changes in the extension (which, among other things, changed the > > diff presentation into a *cough* table), have made it impossible to highlight > > trailing whitespace because the parent elements of the text are no longer > > inline elements and styling their background has no effect. > > The latest changes make the diffs look like crap, IMHO. I'll see if I can change the diffHighlighter to maintain a inline-level element wrapper around the diff text so that background colors can still be applied without highlighting the entire horizontal line but just the text width. WIll probably change <td class="ins">..</td> to be <td><ins>..</ins></td>
Done in r112458. After it gets reviewed and deployed we can test the styling on mw.org and then I'll commit them.
In previous fix HTML entities where showing. Fixed by r112460 Both revisions merged to 1.19wmf1 with r112464 and r112459 have been applied on live site.
Bug fixed in r112511.