Last modified: 2011-02-12 01:11:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29333, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27333 - QueryBloat in page histories
QueryBloat in page histories
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-11 17:04 UTC by Niklas Laxström
Modified: 2011-02-12 01:11 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2011-02-11 17:04:11 UTC 
Viewing history of the main page at translatewiki.net I see 100 identical queries:

0.9479  Query 227 (slave): SELECT /* Title::getNotificationTimestamp Nike */  wl_notificationtimestamp  FROM `bw_watchlist`  WHERE wl_namespace = '0' AND wl_title = 'Main_Page' AND wl_user = '1'  LIMIT 1
Comment 1 Brion Vibber 2011-02-12 01:11:56 UTC 
Fixed in r82004. Title::getNotificationTimestamp() has an internal cache for this which it keeps on the title object, but null entries in the cache were being accidentally ignored due to the way it was checking its cache with isset().

I switched it to use array_key_exists(), which doesn't have this problem, and we now only get a single query issued.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links