Last modified: 2011-03-17 20:01:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29245, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27245 - Android tablets that don't report themselves as "Mobile" should not redirect to mobile site
Android tablets that don't report themselves as "Mobile" should not redirect ...
Status: RESOLVED FIXED
Product: Wikimedia Mobile
Classification: Unclassified
Retired (Ruby) Gateway (Other open bugs)
.5
All All
: Normal enhancement (vote)
: ---
Assigned To: Hampton Catlin
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-08 08:38 UTC by Brion Vibber
Modified: 2011-03-17 20:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2011-02-08 08:38:08 UTC 
Per notes on bug 27238: a more correct version of the tweak in r81128 (since reverted) should be done which keeps non-"Mobile" "Android" devices from redirecting, but without forcing iPad tablets which report being "Mobile Safari" *to* redirect.

It might also be wise to restore the test cases, which were deleted from trunk.
Comment 1 Hampton Catlin 2011-02-08 11:14:37 UTC 
Added back in the test cases. Added new test cases for iPad and Android.

Using the original handling that caused bug 27238, but with a new tweak to
blocks iPad from redirecting.
Comment 2 Brion Vibber 2011-02-08 11:22:13 UTC 
Woops, reopened wrong bug. :)

See my comments on code review for r81714; this regex is super unclear as to
its purpose and is likely very fragile, and the test cases don't appear to
include any cases for the Android 3.0 tablets that the change is meant to
address.
Comment 3 Hampton Catlin 2011-03-17 20:01:23 UTC 
Ok, so the changes were in /trunk for a long time, not the deployment branch for mw1.7, so they weren't actually getting pushed up.

However, now its in the deployment branch and synced.

Client-cache is the main issue. Any existing Non-Mobile android users will have an old
version and might still redirect. However, after a cache clearing, they should be fine.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links