Last modified: 2011-02-08 12:09:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29234, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27234 - Messages do not work in 1.15.1 <= MediaWiki < 1.16
Messages do not work in 1.15.1 <= MediaWiki < 1.16
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Maps (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Jeroen De Dauw
: code-update-regression, easy, i18n
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-08 04:14 UTC by Ben Winslow
Modified: 2011-02-08 12:09 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Fix for version check (465 bytes, patch)
2011-02-08 04:14 UTC, Ben Winslow 		Details
Fix for version check in the Validator extension (practically identical to the Maps diff) (498 bytes, patch)
2011-02-08 04:19 UTC, Ben Winslow 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Ben Winslow 2011-02-08 04:14:20 UTC 
Created attachment 8097 [details]
Fix for version check

In the latest version of the Maps extension, none of the messages work properly in MediaWiki 1.15.x -- instead, only "<string-id>" is inserted into the page (e.g. "<maps-error-invalid-layerdef>".)

After spending a decent chunk of time tearing my hair out, I tracked down the problem to the version check in Maps.php that checks for version 1.16 -- it incorrectly excludes MediaWiki 1.15.x where x > 0.  The attached patch fixes the logic.
Comment 1 Ben Winslow 2011-02-08 04:18:05 UTC 
FYI, this bug exists in Validator as well.  It looks like you have a hand in that extension as well, and since no component exists on this bugzilla for it and the problem/fix is exactly the same, I'm attaching a patch for it to this bug as well.
Comment 2 Ben Winslow 2011-02-08 04:19:16 UTC 
Created attachment 8098 [details]
Fix for version check in the Validator extension (practically identical to the Maps diff)
Comment 3 Jeroen De Dauw 2011-02-08 12:09:30 UTC 
Thanks for reposting the issue; it's already been fixed on svn trunk though :)

I copied the wrong check over to at least 5 extensions before noticing how wrong it was >_>
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links