Last modified: 2014-11-04 20:23:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29193, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27193 - Allow namespace filter for list=deletedrevs&druser
Allow namespace filter for list=deletedrevs&druser
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-06 09:48 UTC by db [inactive,noenotif]
Modified: 2014-11-04 20:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2011-02-06 09:48:47 UTC
Special:DeletedContributions has a namespace filter, but the corresponding api module support the namespace param only for "deleted revisions in the given namespace".

Please allow the namespace filter also work for "deleted contributions for the given user".

Thanks.
Comment 1 Sam Reed (reedy) 2011-04-10 22:27:11 UTC
This seems to be disabled purposely due to the way that the sorts and such are added on by the API, a sane query can be built (ie no filesort)

It's providing a lot more functionality than DeletedContributions does to begin with

We probably need to create a "mode 4"

CREATE INDEX /*i*/name_title_timestamp ON /*_*/archive (ar_namespace,ar_title,ar_timestamp);
CREATE INDEX /*i*/ar_usertext_timestamp ON /*_*/archive (ar_user_text,ar_timestamp);
CREATE INDEX /*i*/ar_revid ON /*_*/archive (ar_rev_id);


  1) List deleted revisions for the given title(s), sorted by timestamp
  2) List deleted contributions for the given user, sorted by timestamp (no titles specified)
  3) List all deleted revisions in the given namespace, sorted by title and timestamp (no titles specified, druser not set)

List deleted contributions for the given user, in the given namespace, sorted by timestamp




SELECT /* IndexPager::reallyDoQuery (DeletedContribsPager) Reedy */  ar_rev_id,ar_namespace,ar_title,ar_timestamp,ar_comment,ar_minor_edit,ar_user,ar_user_text,ar_deleted  FROM `mw_archive` FORCE INDEX (usertext_timestamp) WHERE ar_user_text = 'Reedy' AND ar_namespace = '0' AND ((ar_deleted & 12) != 12)  ORDER BY ar_timestamp DESC LIMIT 51
Comment 2 Sam Reed (reedy) 2011-04-10 22:42:19 UTC
Starting to do this, then hit a snag. By default NS is set to 0... So we can't just do a NS/User filter, and know whether we want to hit 2 or 4..

So people could then unknowingly be filtering by NS 0, which they may or may not want...
Comment 3 Gerrit Notification Bot 2014-10-24 19:19:15 UTC
Change 168646 had a related patch set uploaded by Anomie:
API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions

https://gerrit.wikimedia.org/r/168646
Comment 4 Gerrit Notification Bot 2014-11-04 20:22:09 UTC
Change 168646 merged by jenkins-bot:
API: Split list=deletedrevs into prop=deletedrevisions and list=alldeletedrevisions

https://gerrit.wikimedia.org/r/168646

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links