Last modified: 2014-02-28 13:52:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29147, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27147 - Reflect current revision status in links within CR work flow
Reflect current revision status in links within CR work flow
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-04 00:31 UTC by Krinkle
Modified: 2014-02-28 13:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-02-04 00:31:34 UTC
Within the CodeReview workflow it'd be nice to have some reference to it's current state (kinda like how bugzilla has the .bz_closed class on the links and the "RESOLVED FIXED" in title-attribute /hover tooltip).

Having something like the following:

<a class="mw-codereview-revision-status-new" href="http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270" title="Special:Code/MediaWiki/70270 (reverted)">r70270</a>

or 
<span class="mw-codereview-revision-status-new" title="ialex - reverted"
<a class="" href="http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270">r70270</a></span>

instead of the current output:
<a href="http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70270" title="Special:Code/MediaWiki/70270">r70270</a>

If more people find it helpful, including tags may be useful as well.
Comment 1 Sam Reed (reedy) 2011-02-04 00:34:07 UTC
We have the CSS styles already applied to rows?
Comment 2 Brion Vibber 2011-02-05 00:32:27 UTC
I believe this is meant to be for the inline references in comments and the follow-ups lists, where current there is no check for status and no special formatting.

Should be pretty straightforward to do: pull the record when making the link, and add a css class. This should be abstracted and used consistently for the inline rXXXX and for the generation of paging links and follow-ups.

[It would be SUPER cool if we could find a way to tie this in for bugzilla as well, but that'd be a separate bug. Would need a way to query the wiki cleanly from the BZ side, maybe over API.]
Comment 3 Sam Reed (reedy) 2011-04-10 20:49:41 UTC
And ofcourse now, we have MaxSems popup things...
Comment 4 Krinkle 2011-04-11 13:41:44 UTC
(In reply to comment #2)
> [It would be SUPER cool if we could find a way to tie this in for bugzilla as
> well, but that'd be a separate bug. Would need a way to query the wiki cleanly
> from the BZ side, maybe over API.]

See bug 28489 :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links