Last modified: 2014-05-04 21:37:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29145, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27145 - Fix font declarations
Fix font declarations
Status: RESOLVED DUPLICATE of bug 26204
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: X!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-03 20:56 UTC by Erwin Dokter
Modified: 2014-05-04 21:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erwin Dokter 2011-02-03 20:56:38 UTC
GeSHi is inserting redundant <div style="font-family: monospace;"> and even less necessary <pre style="font-family: monospace;"> into the generated HTML. Redundant because the inline generated CSS already contains the necessary font declaration, and <pre> is already using a monospace font.

The way it is currently declared also has problems in several browsers that cause the text to be too small (see bug 20706, for which a general fix has been applied, but also needs to be applied here), and also interferes with sitewide CSS (ie. common.css).

What needs to be done:
* Remove the inline, hardcoded font styling from the generated HTML (as it is already present in the generated CSS)
* Change the default font declaration in the generated CSS to style="font-family: monospace, 'Courier New';" (see bug 20706 for explanation; the objective is not to prefer Courier New, but to trigger the correct behaviour of those borwsers)
Comment 1 Erwin Dokter 2011-02-03 20:57:32 UTC
*** Bug 26204 has been marked as a duplicate of this bug. ***
Comment 2 Happy-melon 2011-02-03 21:25:16 UTC
We generally mark newer bugs as duplicates of older ones, not the other way around.

*** This bug has been marked as a duplicate of bug 26204 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links