Last modified: 2011-04-21 08:20:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29116, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27116 - trim whitspaces at encapsulation
trim whitspaces at encapsulation
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-02 20:03 UTC by Bergi
Modified: 2011-04-21 08:20 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bergi 2011-02-02 20:03:09 UTC
When you select some words with whitespaces in the end / beginning and click on "Link" or "Bold" or whatever, they are surrounded by the inserted chars instead of beeing trimmed and appended outside of the replacement.

This feature had been provided by the old toolbar in with the function checkSelectedText() in the http://bits.wikimedia.org/skins-1.5/common/edit.js, but it just caught blanks.

Maybe I'm going to try to build my first own patch, but it would be better if someone who already knows the code could do this.
Comment 1 Brion Vibber 2011-02-06 23:37:50 UTC
Could you show an example of what you mean? It sounds like you are describing the current behavior... "they are surrounded by the inserted chars" and "being trimmed and appended outside of the replacement" sound like the same thing to me.
Comment 2 Bergi 2011-02-07 14:05:14 UTC
Current behavior:
bla   blablabla   bla _\ bla ''' blablabla ''' bla 
    ^ selection ^      /
How it should be:
bla   blablabla   bla _\ bla  '''blablabla'''  bla 
    ^ selection ^      /

The whitespaces in the end / beginning of the selection should be ignored. Sorry for my bad English :-)
Comment 3 DieBuche 2011-04-18 09:05:00 UTC
I think I'll work on this.
Comment 4 DieBuche 2011-04-21 08:20:43 UTC
Done in  r86603

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links