Last modified: 2013-04-22 16:16:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29111, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27111 - Double layering ForeignAPIRepo's doesn't retrieve descriptions properly
Double layering ForeignAPIRepo's doesn't retrieve descriptions properly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.18.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-02 18:36 UTC by Bawolff (Brian Wolff)
Modified: 2013-04-22 16:16 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2011-02-02 18:36:10 UTC
Set up:

*Wiki 1 - $wgUseInstantCommons = true;
*Wiki 2 - Using ForeignApiRepo to get images from wiki 1.

Consider [[commons:Image:Example.svg]].

Wiki 1 displays the description page from commons like it should.

Wiki 2 displays:
This file is from a shared repository and may be used by other projects. The description on its file description page<link to commons> there is shown below.

There is currently no text in this page. You can search for this page title in other pages, search the related logs, or edit this page.

-----
Expected behaviour is for Wiki 2 to display the description page from commons. At the very least it shouldn't display the no page exists text.

The quickest fix would probably be to do the same stuff we do for adding the foreign  description page on action=view, on action=render. A more proper fix would probably be to fetch the description page directly from the right repository.
Comment 1 Krinkle 2012-01-08 02:15:20 UTC
Does this also happen for people using en.wikipedia as file repository ?

Raising severity as this makes it harder for larger wiki (farm)s using commons as their repo to have their own repo as well.

Description pages on wiki 2 shouldn't show a page suggesting there is no description page.
Comment 2 Bawolff (Brian Wolff) 2012-01-08 19:07:20 UTC
(In reply to comment #1)
> Does this also happen for people using en.wikipedia as file repository ?

yes. We just use ?action=render which gives stuff like: http://en.wikipedia.org/wiki/File:Example.svg?action=render

Easy fix I suppose is put the magically inserted text from the other repo into the ?action=render output. Would anything break doing that? (I personally can't think of anything)
Comment 3 DaSch 2012-07-20 11:04:59 UTC
This problem still exists in 1.20 and this is a big problem! because the license is not shown so I'm a bit concerned about the copyright legal things.
Comment 4 Bawolff (Brian Wolff) 2012-08-19 20:35:47 UTC
(In reply to comment #3)
> This problem still exists in 1.20 and this is a big problem! because the
> license is not shown so I'm a bit concerned about the copyright legal things.

1.20 Ain't done yet! ;) Gerrit change #20660
Comment 5 matanya 2012-08-25 23:03:47 UTC
patch merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links