Last modified: 2011-02-08 22:01:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29096, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27096 - CodeReview has invalid CSS
CodeReview has invalid CSS
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://jigsaw.w3.org/css-validator/va...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-02 00:20 UTC by Sam Reed (reedy)
Modified: 2011-02-08 22:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-02-02 00:20:38 UTC
w3 reckons 1 error, and 5 warnings

135	 .mw-codereview-diff .meta	 Value Error : color darkcyan is not a color value : darkcyan darkcyan

Warnings:
163		Same colors for color and background-color in two contexts .mw-codereview-struck td and .mw-wordcloud-size-5
163		Same colors for color and background-color in two contexts .mw-codereview-status-reverted:hover td and .mw-wordcloud-size-5
163		Same colors for color and background-color in two contexts .mw-codereview-status-reverted:hover and .mw-wordcloud-size-5
175		Same colors for color and background-color in two contexts .mw-codereview-status-reverted td and .mw-wordcloud-size-8
175		Same colors for color and background-color in two contexts .mw-codereview-status-reverted and .mw-wordcloud-size-8


See url for direct link to http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/modules/ext.codereview.css?view=co in the w3 validator
Comment 1 Sam Reed (reedy) 2011-02-02 00:29:47 UTC
Can we just use #008b8b instead to make it happy? :S At least for the error...
Comment 2 Brion Vibber 2011-02-02 00:30:45 UTC
Nobody really uses the CSS validator much as it tends to come up with warnings that are... dubious.

The warnings here don't make any sense; does it think that .mw-codereview-struck and .mw-wordcloud-size-5 are going to be used in the same place? These are not actually problems at all, as those class styles are never used together.

'darkcyan' is indeed technically not listed in CSS 2.1, but it is standard in the CSS 3 colors module and is supported by all known browsers. Wouldn't hurt to swap it to a hex code, but not a lot of reason for it either.
Comment 3 Sam Reed (reedy) 2011-02-02 11:40:35 UTC
WONTFIX then?
Comment 4 MZMcBride 2011-02-04 23:20:19 UTC
(In reply to comment #3)
> WONTFIX then?

Let's go with "fixed" once "darkcyan" is removed. The description text can go in a CSS comment next to the hex code for clarification.

The warnings can safely be ignored.
Comment 5 Brion Vibber 2011-02-05 00:45:31 UTC
darkcyan -> hex done in r81548

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links