Last modified: 2011-03-08 08:08:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29067, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27067 - Fetch MediaWiki:Filedelete-reason-dropdown from MediaWiki:Deletereason-dropdown.
Fetch MediaWiki:Filedelete-reason-dropdown from MediaWiki:Deletereason-dropdown.
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-31 13:31 UTC by Rehman
Modified: 2011-03-08 08:08 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rehman 2011-01-31 13:31:47 UTC
The deletion dropdown at Commons currently fetches from two pages:
* MediaWiki:Deletereason-dropdown
* MediaWiki:Filedelete-reason-dropdown

It would be more efficient to fetch from a single page, preferable the first. A simple switch function could be placed to work as it does currently. This would avoid duplicating general deletion criteria between both pages.

This was discussed and considered an uncontroversial change.
Comment 1 Chad H. 2011-01-31 13:38:12 UTC
Um, only Filedelete-reason-dropdown should be shown on file deletion pages, why are there two?
Comment 2 Rehman 2011-02-11 07:20:46 UTC
(In reply to comment #1)
> Um, only Filedelete-reason-dropdown should be shown on file deletion pages, why
> are there two?

Exactly. So thats the reason of this request; remove the fetching of the second page...
Comment 3 p858snake 2011-02-11 07:23:07 UTC
(In reply to comment #1)
> Um, only Filedelete-reason-dropdown should be shown on file deletion pages, why
> are there two?

I think deletereason is ment to a "common" list, but its pointless if we don't have a dedicated page/article list for deletions.
Comment 4 Rehman 2011-02-11 07:27:58 UTC
(In reply to comment #3)
> I think deletereason is ment to a "common" list, but its pointless if we don't
> have a dedicated page/article list for deletions.

Am working on creating a detailed page for the deletion criteria:
http://commons.wikimedia.org/wiki/User:Rehman/Proposals/Deletion_criteria

This is just the first step...
Comment 5 Rehman 2011-03-06 06:16:19 UTC
The change is uncontroversial, I don't see why it should take so long to do it...
Comment 6 Bawolff (Brian Wolff) 2011-03-06 06:31:15 UTC
Just to clarify, you are reporting:
*Normal articles use: Deletereason-dropdown
*File delete pages use: Filedelete-reason-dropdown
for their respective delete reason drop down list, where instead you want both pages to use Deletereason-dropdown, and want Filedelete-reason-dropdown to no longer do anything? With the reason being its less work for admins to maintain a single list.


The first time I read this I thought you were complaining that file deletion pages had both dropdowns on them.

>This was discussed and considered an uncontroversial change.

btw, its extraordinary unlikely that this would be changed just for commons. It will probably be changed either for everyone, or no one. (Or it might be changed so that if filedelete-reason-dropdown is empty, the file deletion page would use the normal drop down instead). Per-wiki configuration is not this fine grained.
Comment 7 Rehman 2011-03-06 06:34:49 UTC
(In reply to comment #6)
> btw, its extraordinary unlikely that this would be changed just for commons. It
> will probably be changed either for everyone, or no one. (Or it might be
> changed so that if filedelete-reason-dropdown is empty, the file deletion page
> would use the normal drop down instead). Per-wiki configuration is not this
> fine grained.

So if I just delete the "filedelete-reason-dropdown" from Commons, would that solve the problem?
Comment 8 Bawolff (Brian Wolff) 2011-03-06 06:38:47 UTC
No, I'm saying one potenital solution is to change it so that if the message is empty that behaviour would happen, that is not the current behaviour.
Comment 9 Rehman 2011-03-06 06:42:24 UTC
(In reply to comment #8)
> No, I'm saying one potenital solution is to change it so that if the message is
> empty that behaviour would happen, that is not the current behaviour.

Please forgive me, but I don't understand. ;) So, if I blank "Filedelete-reason-dropdown" (not delete), it would fetch only from "Deletereason-dropdown"?

Or are you saying that this feature of "dont fetch if blank" is something that could be implemented?
Comment 10 Bawolff (Brian Wolff) 2011-03-06 06:51:49 UTC
It could be implemented. It is not right now.

The only way to do it as the code is now without modifying the code is to replace mediawiki:Filedelete-reason-dropdown  with {{mediawiki:Deletereason-dropdown}}. Then it would load from the other one (Its disgusting that that works, but meh. I only thought of it because i noticed you guys used parser funcs on the pages on commons).
Comment 11 Rehman 2011-03-08 06:56:45 UTC
(In reply to comment #10)
> The only way to do it as the code is now without modifying the code is to
> replace mediawiki:Filedelete-reason-dropdown  with
> {{mediawiki:Deletereason-dropdown}}. Then it would load from the other one (Its
> disgusting that that works, but meh. I only thought of it because i noticed you
> guys used parser funcs on the pages on commons).

Okay seems to be working :) Any idea what would happen if "Filedelete-reason-dropdown" is deleted?
Comment 12 Krinkle 2011-03-08 08:08:36 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > The only way to do it as the code is now without modifying the code is to
> > replace mediawiki:Filedelete-reason-dropdown  with
> > {{mediawiki:Deletereason-dropdown}}. Then it would load from the other one (Its
> > disgusting that that works, but meh. I only thought of it because i noticed you
> > guys used parser funcs on the pages on commons).
> 
> Okay seems to be working :) Any idea what would happen if
> "Filedelete-reason-dropdown" is deleted?

Then it will fallback to the default value of the message, like any other message in the software. Which is:
*Common delete reasons\ **Copyright violation\ **Duplicated file.


Marking invalid as this is neither a feature request nor a bug in the software.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links