Last modified: 2011-01-30 16:58:48 UTC
Upload stash seems to fail for paged media (pdf's is what i tested. But same issue presumably applies to other paged formats like Djvu, and other "weird" formats like ogg most likely). This seems to be because SpecialUploadStash only accounts for width parameters to be at the begining of the thumbnail name. It doesn't look for a page parameter. Handler's can define there own parameter, so this would also break for things like oggHandler, which can have a seek parameter for where in the video the image was pulled from. As a secondary issue, UploadStash doesn't support files with multiple extensions (key is not in proper format...), which happens for pdf's (And some other non-image formats) since the thumbnail is jpg, but the original is pdf. so the filename of a thumb ends up being page1-100px-foo.pdf.jpg
Just to clarify, this is for showing thumbnails. Downloading the original files is just fine. I'm not really sure how showing thumbnails from upload stash is used, so i'm not sure how big an issue this is. But you can make a query using stashimageinfo api module, get a url for a thumbnail, but then have the url totally not work.
UploadStash should use the proper MediaHandler::*Params() functions instead of doing the regex themselves. It should also use different base urls for thumbnails and files; I propose Special:UploadStash/file/ and Special:Upload/thumb/
Fixed in r81209.
