Wikimedia Bugzilla is closed!

The three foreach() loops here:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialWhatlinkshere.php?revision=80409&view=markup#l188

overwrite eachother. That was done to avoid duplicates. However the props are also rewritten.

Perhaps a check to see if it's been set already should be done and merge the is_template/is_image props.

Although we could choose to simply decide to let one count strong than the other (in this case imagelink, over templatelink, over pagelink) however the following part of the code is clearly designed with the scenario in mind that multiple props are set to 1:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialWhatlinkshere.php?revision=80409&view=markup#l292
<pre>
298                if ( $row->is_template )
299	                        $props[] = $msgcache['istemplate'];
300	                if( $row->is_image )
301	                        $props[] = $msgcache['isimage'];
302	
303	                if ( count( $props ) ) {
304	                        $propsText = '(' . implode( $msgcache['semicolon-separator'], $props ) . ')';
305	                }
</pre>