Last modified: 2012-04-12 13:54:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28895, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26895 - in /include/db/LoadBalancer.php function "closeConnecton" should be called "closeConnection"
in /include/db/LoadBalancer.php function "closeConnecton" should be called "c...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-23 21:17 UTC by sandb
Modified: 2012-04-12 13:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description sandb 2011-01-23 21:17:43 UTC 
In /include/db/LoadBalancer.php it seems to me the closeConnecton function is wrongly named (typo).

Propose marking it deprecated or so and adding a new function called "closeConnection" with the old "closeConnecton" linking to the new one.
Comment 1 Sam Reed (reedy) 2011-01-24 01:01:30 UTC 
Seemingly there is nothing calling it in phase3 or extensions

Fixed in r80841, leaving the back compat method behind. Though, I'm not quite sure it's needed

It was added in r32578, and not changed since seemingly...
Comment 2 sandb 2011-01-24 10:15:24 UTC 
Thx Reedy, that was fast!

I'm using the function in an extension I'm writing: http://www.mediawiki.org/wiki/Extension:KeyValue

There might be others using it, or maybe I should not be using it...

Thx in any case! (not sure, should I close the bug now?)
Comment 3 Sam Reed (reedy) 2011-01-24 10:21:38 UTC 
RESOLVED it now. Whether to bother keeping the back compat method is something that'll get resolved in the code review
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links