Last modified: 2011-02-08 21:57:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28886, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26886 - Move toggle for DoubleWiki to InitialiseSettings.php
Move toggle for DoubleWiki to InitialiseSettings.php
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-23 14:13 UTC by Krinkle
Modified: 2011-02-08 21:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-01-23 14:13:26 UTC
Current code>
<pre>
## CommonSettings.php

// Experimental side-by-side comparison extension for wikisource. enabled brion 2006-01-13
// FIXME: Needs $wmgUseDoubleWiki in InitialiseSettings.php
if(
    'wikisource' == $site || 'sourceswiki' == $db || 'frwiktionary' == $wgDBname ) {
    include( $IP.'/extensions/DoubleWiki/DoubleWiki.php' );
}
</pre>

This should be moved to init like the other per-wiki settings (makes searching a lot easier).

I don't know the exact syntax, but I think something like this:
<pre>
## InitialiseSettings.php

'wmgUseDoubleWiki' => array( 
	'default' => false, 
	'wikisource' => true,
	'sourceswiki' => true,
	'frwiktionary' => true,
),


## CommonSettings.php

// Experimental side-by-side comparison extension for wikisource. enabled brion 2006-01-13
if( $wmgUseDoubleWiki ) {
    include( $IP.'/extensions/DoubleWiki/DoubleWiki.php' );
}
</pre>
Comment 1 JeLuF 2011-01-23 15:19:10 UTC
Your change has been completed.
Please reopen this ticket if anything went wrong.
The following configuration settings have been changed:
===================================================================
Index: InitialiseSettings.php
===================================================================
--- InitialiseSettings.php	(revision 1534)
+++ InitialiseSettings.php	(working copy)
@@ -8603,5 +8603,13 @@
     'default' => false,
     'foundationwiki' => true,
 ),
+
+'wmgUseDoubleWiki' => array( 
+    'default' => false, 
+    'wikisource' => true,
+    'sourceswiki' => true,
+    'frwiktionary' => true,
+),
+
 );
 
===================================================================
You can find the entire config file at
http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php
Comment 2 Krinkle 2011-01-23 22:14:26 UTC
Could you also remove the note or add something below it. It's a little confusing (since it's been added to InitialiseSettings.php now)
<pre>
// FIXME: Needs $wmgUseDoubleWiki in InitialiseSettings.php
</pre>
Comment 3 Roan Kattouw 2011-01-24 02:42:56 UTC
(In reply to comment #2)
> Could you also remove the note or add something below it. It's a little
> confusing (since it's been added to InitialiseSettings.php now)
> <pre>
> // FIXME: Needs $wmgUseDoubleWiki in InitialiseSettings.php
> </pre>
I've removed it locally. It probably won't show up on noc until the next change to CommonSettings is synced; I didn't think syncing for a comment removal was really necessary.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links