Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28879, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 26879 - Usage of $replyTarget on line 40 of ui/CodeRevisionView.php is undefined

Summary:	Usage of $replyTarget on line 40 of ui/CodeRevisionView.php is undefined

Status: RESOLVED WORKSFORME Product: MediaWiki extensions Classification: Unclassified Component: CodeReview (Other open bugs) Version: unspecified Hardware: All All Importance: Normal minor (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2011-01-23 09:08 UTC by Sam Reed (reedy) Modified: 2011-01-25 22:03 UTC (History) CC List: 3 users (show) innocentkiller mah sam See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-01-23 09:08:57 UTC Usage of $replyTarget on line 40 of ui/CodeRevisionView.php is undefined http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionView.php?view=annotate attributes it to r48132, but r1=48131&r2=48132">http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/CodeRevisionView.php?&pathrev=48132&r1=48131&r2=48132 seems to disagree... Comment 1 Mark A. Hershberger 2011-01-25 21:56:16 UTC ??? $replyTarget is assigned null in the function's definition that "svn annotate" says you created in r76913. Comment 2 Sam Reed (reedy) 2011-01-25 22:03:18 UTC I changed $repoName to $repo, and added function documentation... But anyway, WFM is right, it's an IDE bug