Last modified: 2012-11-09 14:13:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28878, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26878 - Don't serve <script>fixalpha()</script> unconditionally from the server side
Don't serve <script>fixalpha()</script> unconditionally from the server side
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: 1.20.x release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-23 03:15 UTC by Sam Reed (reedy)
Modified: 2012-11-09 14:13 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-01-23 03:15:11 UTC 
<!-- fixalpha --> 
		<script type="text/javascript"> if ( window.isMSIE55 ) fixalpha(); </script> 
		<!-- /fixalpha --> 

Should really only be served to IE5.5 browsers, no? :)
Comment 1 Sam Reed (reedy) 2011-01-23 03:24:35 UTC 
Almost... Shouldn't it be in wikibits.js/the usage of IEFixes.js?

As it's seemingly done in Vector/Monobook themselves, and in IEFixes.js in a different way....

Bleh
Comment 2 Krinkle 2011-01-23 03:35:01 UTC 
Serving through PHP would break the cache or otherwise mess things up afaik.
But a seperate <script> element for it seems unneeded indeed, should be simple to move.

Although note that it should not run at document.ready but window.ready (not sure what the exact reason was, but I imagine it has to to with images being loaded or not)
Comment 3 Bugmeister Bot 2011-08-19 19:12:56 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 4 Krinkle 2012-07-15 15:06:25 UTC 
Moving javascript-related bugs not related to ResourceLoader to JavaScript. This has no association with the ResourceLoader framework itself.

Also assigning to myself.
Comment 5 Krinkle 2012-11-09 14:12:00 UTC 
This was already done in r107327 (and followed-up in r108885). Not sure how/why it was put back in the HTML output?
Comment 6 Krinkle 2012-11-09 14:13:25 UTC 
Hm.. actually, they weren't put back. I fixed this bug in the aforementioned revisions. Marking fixed!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links