Last modified: 2013-12-26 14:50:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28875, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26875 - Add support for Anonnotice to DismissableSitenotice
Add support for Anonnotice to DismissableSitenotice
Status: RESOLVED DUPLICATE of bug 57732
Product: MediaWiki extensions
Classification: Unclassified
DismissableSiteNotice (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-22 21:52 UTC by Krinkle
Modified: 2013-12-26 14:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-01-22 21:52:59 UTC
The contents of the sitenotice fallback to Anonnotice for non users if it's message  is not empty.
However it's not dismissable.
Comment 1 Brion Vibber 2011-01-22 21:57:51 UTC
DismissableSitenotice only checks whether the session is for a logged-in user or not. It calls into core code to get whatever the currently-applicable site notice text will be; presence or absence of an anonnotice setting will have no effect on this behavior.

Fix would be to remove that one 'if' line, so the dismissible notice display gets used for all visitors. Should also double-check that the cookie for saving the dismissal state is properly ignored for caching.
Comment 2 Dror S. 2013-12-26 14:50:58 UTC

*** This bug has been marked as a duplicate of bug 57732 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links