Last modified: 2011-03-22 13:57:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28866, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26866 - remove trackback user right from DefaultSettings.php
remove trackback user right from DefaultSettings.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-22 18:04 UTC by Umherirrender
Modified: 2011-03-22 13:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2011-01-22 18:04:03 UTC
When $wgUseTrackbacks is false, there is no need for adding the user right 'trackback' per default to user group sysop.

Maybe remove that user right per comment out or per condition on $wgUseTrackbacks.

Thanks.
Comment 1 Bawolff (Brian Wolff) 2011-01-24 02:05:47 UTC
As it stands, all sorts of rights are added to various user groups for disabled by default features (Upload by url comes to mind). I think this should be wontfixed.
Comment 2 Chad H. 2011-01-25 05:39:14 UTC
Yes, this and bug 26868 should both be WONTFIX'd.

We cannot conditionally set it in DefaultSettings, as any changes made in LocalSettings will not yet have taken effect.

We *could* remove the right from sysops in Setup, but that only affects the default case and doesn't remove the right(s) from groups that might have had them assigned (but the corresponding feature has been disabled).

In any case...the user still *has* the rights, the feature has been disabled by other means.
Comment 3 Umherirrender 2011-01-28 15:42:34 UTC
(In reply to comment #2)
> We *could* remove the right from sysops in Setup, but that only affects the
> default case and doesn't remove the right(s) from groups that might have had
> them assigned (but the corresponding feature has been disabled).

Why not? When the corrosponding feature is disabled per default ,the user right should be removed (or comment out) from DefaultSettings.php also.

Thanks.
Comment 4 Chad H. 2011-01-28 17:07:14 UTC
You can't do it in DefaultSettings because it doesn't give the user a chance to override it. The default is false, the user permission would be unassigned by default. Now, to enable trackbacks you'd have to enable it *and* assign the permission which is counterintuitive.

I guess we could remove the default case in Setup. It wouldn't on the edge case of someone assigning the trackback permission to another group but disabling the feature...but if you're doing that you're doing something wrong anyway :)
Comment 5 Chad H. 2011-03-22 13:57:51 UTC
Went ahead and commented it out in r84527, added a RELEASE-NOTES entry for the (probably very few) people using this feature.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links