Last modified: 2011-01-22 17:02:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28861, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26861 - OutputPage::addVaryHeader throws a warning
OutputPage::addVaryHeader throws a warning
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.18.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-22 13:03 UTC by Niklas Laxström
Modified: 2011-01-22 17:02 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2011-01-22 13:03:58 UTC
OutputPage::addVaryHeader throws a warning when the second parameter is null in array_unique in that method.
Comment 1 Brion Vibber 2011-01-22 17:02:36 UTC
r80755 should clear it up; the null wasn't actually getting forced to an empty array, which it seems to prefer.

Though.... I notice down in getXVO it seems to want to append options for the X-Vary-Options sections as long as there's an array, even if it's empty, which is probably wrong.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links