Last modified: 2014-03-09 18:04:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28860, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26860 - Mediawiki:Geshi.css imported multiple times
Mediawiki:Geshi.css imported multiple times
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Hello_wo...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-22 10:17 UTC by Michael M.
Modified: 2014-03-09 18:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Partial patch; see comment for issues with ordering (1.82 KB, patch)
2011-01-22 17:27 UTC, Brion Vibber
Details

Description Michael M. 2011-01-22 10:17:44 UTC
Mediawiki:Geshi.css is imported multiple times, once for each language. This is a bit messy when you debug your own CSS with e.g. Web Developer Toolbar and have to go through many CSS files with the same content until you find your code.
Comment 1 Brion Vibber 2011-01-22 17:27:37 UTC
Created attachment 8018 [details]
Partial patch; see comment for issues with ordering

It's relatively easy to split the style blocks into separate head items for the language-specific styles and the site-specific overrides, which would let OutputPage automatically sort out the dupes and only actually output one instance of the including of MediaWiki:Geshi.css

*However*... there's a catch. :) The purpose of the customizable styles is to allow people to override the GeSHi default styles; to accomplish this it must be included *after* all the default style blocks.

If we make it its own separate head item, it'll get included after the first language style block, but *before* any subsequent ones. Custom styles with the same selector priority as those in the default styles could get overridden back to the defaults, and not be very easy to debug -- especially since most of the time there'll probably only be a single language per page and the bug won't bee seen.

(!important entries can force an override, but folks likely won't know they need it.)

If it can be pushed down below later invocations of the plugin, then it'll do the job.
Comment 2 Bugmeister Bot 2011-08-19 19:12:43 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Umherirrender 2013-04-13 19:30:14 UTC
Looks indirect fixed by now using the resourceloader (bug 27714)?
Comment 4 Andre Klapper 2013-04-25 11:56:18 UTC
Michael / Brion: Was this fixed by using resourceloader (bug 27714)?
Comment 5 Andre Klapper 2013-06-25 13:15:42 UTC
Michael / Brion: Was this fixed by using resourceloader (bug 27714)?
Comment 6 Lewis Cawte 2013-10-24 21:18:39 UTC
As far as I can tell, using the page listed in the URL, ext.geshi.local only appears once. If anyone else wants to confirm this, or has a better way of testing/checking it, please do!
Comment 7 Umherirrender 2014-02-15 18:46:38 UTC
FIXED per comment 3

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links