Last modified: 2013-04-02 18:51:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28849, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26849 - Update padding construction in Monobook #content and #firstHeading to be more like Vector
Update padding construction in Monobook #content and #firstHeading to be more...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: 1.21.0 release
Assigned To: Rahul Maliakkal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-21 18:34 UTC by Bergi
Modified: 2013-04-02 18:51 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch (475 bytes, patch)
2011-03-10 19:20 UTC, Bergi
Details

Description Bergi 2011-01-21 18:34:36 UTC
Today the content has a padding-top of 0, while the firstheading gets a padding-top: .5em; (inherited from h1). Vector already has changed this to 
div#content { padding-top: 1em; }
#firstHeading { padding-top: 0; }
which I suggest also for monobook. This would make any elements before the firstheading look alike in the various skins. It would notably affekt the central- or sitenotice, which often needs extra, skin-dependent css, mostly when there are absolutely positioned objects (coordinates etc.) at the top of the page.

This may refer to Bug 2013.

Also look at [[de:Wikipedia:Administratoren/Anfragen#centralNotice in MediaWiki:Monobook.css]].
Comment 1 Bergi 2011-01-26 15:18:12 UTC
I think this should be fixed separatly from Bug 2013, theres no dependence.
I just wanted to link it because it deals with Heading-font-size, too; but after a bit of mediation I'm now afraid I just misunderstood its request.
Comment 2 Bergi 2011-03-10 19:20:40 UTC
Created attachment 8278 [details]
proposed patch
Comment 3 p858snake 2011-04-30 00:09:38 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 4 Sumana Harihareswara 2011-11-09 02:54:46 UTC
+need-review to signal to developers that this patch needs reviewing
Comment 5 Derk-Jan Hartman 2012-02-26 15:42:02 UTC
I see no problem with this patch, other than that it would break all the MediaWiki:Monobook.css pages with definitions for topicons and the likes. Not major, but would need good communication towards the community.
Comment 6 Sumana Harihareswara 2012-03-10 19:55:57 UTC
Bergi, can you respond to Derk-Jan's comment?  Do you think we should avoid breaking those pages, or break those pages and communicate systematically with the community ahead of time?
Comment 7 Bergi 2012-03-10 22:18:06 UTC
It wouldn't really break them, just the topicons would be 1em below their current position. Surely, it needs to be communicated, but I think we should do it because the cleaner implementation makes custom css easier.
Comment 8 Rahul Maliakkal 2013-03-30 21:53:15 UTC
Gerrit change #56760
Comment 9 Krinkle 2013-04-02 18:50:47 UTC
Change-Id: Iab04baea4131208373962e4ddf7c8ac83c7f2ca9

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links