Last modified: 2014-09-23 23:09:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28808, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26808 - Run $wgSpamRegex on Account registration
Run $wgSpamRegex on Account registration
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-19 19:58 UTC by Subfader
Modified: 2014-09-23 23:09 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Spam check in user name and email validity checks (820 bytes, patch)
2011-01-31 12:32 UTC, Matěj Grabovský
Details

Description Subfader 2011-01-19 19:58:40 UTC
$wgSpamRegex should be checked against the user name and e-mail address on accoutn registration.
Comment 1 Subfader 2011-01-30 22:45:53 UTC
inside function addNewAccountInternal():

    # spam check
    global $wgSpamRegex;
    if ($wgSpamRegex) {
      if ( preg_match( $wgSpamRegex, $this->mEmail ) ) {
        $this->mainLoginForm( wfMsg( 'detectedSpam' ) );
        return false;
      }
    }
Comment 2 Subfader 2011-01-30 22:48:04 UTC
^^ This only checks the email address tho
Comment 3 Matěj Grabovský 2011-01-31 12:32:37 UTC
Created attachment 8072 [details]
Spam check in user name and email validity checks

Wouldn't it be better to check for spam right in User's checks validity of username and email?
Comment 4 Subfader 2011-02-05 22:37:59 UTC
you're right. moved it to the top of addNewAccount()
Comment 5 Subfader 2011-02-05 22:43:41 UTC
wait. I only wanted to block new spam bits with certain e-mail adresses like da.vid.smi.th.999@gmail.com

if you think that's better ok, no idea.
Comment 6 p858snake 2011-04-30 00:09:07 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 7 Sumana Harihareswara 2011-11-10 03:03:41 UTC
Matěj Grabovský, thank you for the patch, and sorry for the wait.  I'm adding the "need-review" keyword so that developers know to review your patch.  Thanks again.
Comment 8 Sam Reed (reedy) 2011-11-20 18:20:43 UTC
First part of the patch is fine and applyable (looks fine).

As for the 2nd part, that's moved to the Sanitizer

As it's a function called "validateEmail", I'm dubious about adding random MW specific blocking code in there

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links