Last modified: 2013-03-06 05:27:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28804, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26804 - ResourceLoader should not fail when registering module by name of empty string
ResourceLoader should not fail when registering module by name of empty string
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-19 03:26 UTC by Michael Dale
Modified: 2013-03-06 05:27 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael Dale 2011-01-19 03:26:29 UTC 
* ( multiple methods calls to generate local variables ) in ResourceLoader::preloadModuleInfo you set $skin to $context->getSkin(); then for db select call $context->getSkin(); again.

* In the register call you should check and throw an error for an empty $name argument since it fails in mysterious ways if you happen to mess up your array merges before your register calls.
Comment 1 Krinkle 2011-05-04 21:00:37 UTC 
First one fixed in r87453.
Comment 2 Bugmeister Bot 2011-08-19 19:12:56 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links