Last modified: 2012-04-16 09:15:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28802, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26802 - Optimizations in resource loader filestat checks?
Optimizations in resource loader filestat checks?
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-19 03:25 UTC by Michael Dale
Modified: 2012-04-16 09:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael Dale 2011-01-19 03:25:54 UTC
Feel free to close this quickly if I miss read the code...

afaict after preloadModuleInfo we validate the cache for every logged in user? Does this mean we running filestat for every resource file every 5 min for every logged in user?  If not already doing this, the RL could use global filestat times cache so its not validated for every logged in user so often? 

* Top level svn file reading. You could save a lot of filestat calls by just parsing revision from directory level svn files ( if available ). 

* The majority of mediaWiki installs they simply won't be modifying any of the release files, a global like $wgResourceLoaderCheckForFileChanges = false by default might not be a bad idea. 

What does ResourceLoaderFileModule::getModifiedTime-filemtime profile time look like for sites without squid in-front of mediaWiki? 

Maybe this is a non issue because of operating system level filestat cache? But might be painful for sites on network file systems.
Comment 1 Roan Kattouw 2011-01-19 18:14:45 UTC
(In reply to comment #0)
> Feel free to close this quickly if I miss read the code...
> 
You are misunderstanding something, yes.

> afaict after preloadModuleInfo we validate the cache for every logged in user?
No. Squid caches for *content* are bypassed for logged-in users. The Varnish caches for load.php are shared across all users, logged-in or not (except for the per-user things of course), so the startup module is regenerated once every 5 minutes, not per user per 5 minutes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links