Last modified: 2014-11-17 10:35:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2679 - Show category links above the edit box
Show category links above the edit box
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Low enhancement with 4 votes (vote)
: ---
Assigned To: Jan Kucera (Kozuch)
: design, easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-03 01:38 UTC by Puzzlet Chung
Modified: 2014-11-17 10:35 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Puzzlet Chung 2005-07-03 01:38:14 UTC
When editing a page, I'm not sure about the names of category pages I would like
to add sometimes, so I press Alt+P(for Preview) to check, but I would find no
category links on the preview.
Comment 1 Brion Vibber 2005-07-03 01:39:55 UTC
In MonoBook they show at the bottom of the page, below the edit box.
Comment 2 Puzzlet Chung 2005-08-10 07:55:24 UTC
Well, I have never realized the category links placed below the edit box! 
I think showing category links above the edit box would be more reasonable.
Comment 3 Brion Vibber 2008-10-09 23:27:41 UTC
Since its original introduction, category display is part of the skin. Some skins put them at the top (the old Standard skin, Cologne Blue), others put them at the bottom (MonoBook).

This ends up looking weird in edits previews, since the category links are still shown by the skin for the whole page, and can be separated from the preview part of the page by the edit box.

This is kind of silly. :)

Probably we should retool it so the category links are shown sensibly near the page text, which would be predictable in the case of previews.
Comment 4 Bartosz Dziewoński 2012-10-21 15:29:50 UTC
I'll be bold and WONTFIX this. Category display is part of a skin, and it's exactly the same during regular viewing as during editing/previewing.

Not to mention that there is a preference for showing the edit box above/below preview, which further complicates things.
Comment 5 MZMcBride 2012-10-21 23:14:08 UTC
(In reply to comment #4)
> I'll be bold and WONTFIX this. Category display is part of a skin, and it's
> exactly the same during regular viewing as during editing/previewing.

I didn't notice the category links during preview for years. This is a real user interface issue that should be addressed properly.
Comment 6 Bartosz Dziewoński 2012-10-22 17:39:06 UTC
This is not limited to categories, then, as language links are previewed similarly, except they're even less visible, being placed in the sidebar instead of in the content. (The whole thing with langlinks in the sidebar is weird, but that's a topic for a different discussion.)

And, obviously, this would have to be solved on a per-skin basis.

Also, what kind of design do you suggest? What could be clearer than exactly the same behavior as during reading?

And where would we stuff them? Recent trend seems to be to de-clutter the edit form itself, so it can't go around there. Above the preview? That would seem like "forcing" the categories on the user, and I'd say they are changed comparably rarely – and it could also suggest that the edit, unrelated to categories, did something unintended, as they would not be shown there during reading. Down below? Well, that's where they are now (on most of the skins) – maybe above the templates list would be better, I don't know – but then there's also the hidden categories list, which is rendered differently for people who have them hidden during reading (the default). Maybe to the side? Nah, just kidding.
Comment 7 MZMcBride 2012-10-22 21:31:58 UTC
(In reply to comment #6)
> Also, what kind of design do you suggest? What could be clearer than exactly
> the same behavior as during reading?

Above the textarea, of course. :-)

When you click edit and then click preview, you currently have something like this:

---
[page title]

[content]

[textarea]

[category links]
---

Instead, it should be something like this:

---
[page title]

[content]

[category links]

[textarea]
---

This way, when a user is scrolling down through the page, they can see the category links above the textarea with all of the other content.
Comment 8 Nemo 2013-01-11 18:48:11 UTC
-easy: there are still design doubts so it's not.
Comment 9 MZMcBride 2013-01-12 05:13:45 UTC
(In reply to comment #8)
> -easy: there are still design doubts so it's not.

No there aren't. Restoring the keyword. Also, stop assuming that because a bug is marked as easy that it requires no thought. This is a stupid assumption.
Comment 10 Jan Kucera (Kozuch) 2013-01-27 15:00:56 UTC
Seems like this bug could be solved within function displayPreviewArea in /includes/EditPage.php. Unfortunatelly I do not know how to print out the cats within this function...
Comment 11 Jesús Martínez Novo (Ciencia Al Poder) 2013-02-02 13:09:10 UTC
Jan submitted Gerrit change #47212 for fixing this.
Comment 12 Jan Kucera (Kozuch) 2013-02-17 12:10:20 UTC
I am stuck with the patch half way through... the category links were added above the edit box but I can not get rid of them from below the box... any hint appreciated.
Comment 13 Jan Kucera (Kozuch) 2013-02-18 10:35:50 UTC
I figured out what I needed (how to hide the links below box on preview). But I see the bug has multiple possible solutions. So I ask - do we want to strip the categories from the skins completely and make them show BELOW the article on all skins by default? Some skins show category links at the top of page - do we want to keep them doing that even on preview page or not?
Comment 14 Jan Kucera (Kozuch) 2013-02-19 11:50:37 UTC
I finally decided to only go with the Vector skin. A new patch set was submitted for review implementing this particular solution.
Comment 15 Gerrit Notification Bot 2013-11-03 08:26:58 UTC
Change 47212 had a related patch set uploaded by Nemo bis:
(bug 2679) Adding category links above the edit box

https://gerrit.wikimedia.org/r/47212
Comment 16 Nemo 2013-11-03 08:29:12 UTC
I don't understand, how does this work with the preference to have the preview before or after the edit box? Because if one wants it after, categories at top would just be clutter.
Comment 17 MZMcBride 2013-11-03 23:31:15 UTC
(In reply to comment #16)
> I don't understand, how does this work with the preference to have the
> preview before or after the edit box? Because if one wants it after,
> categories at top would just be clutter.

As I understand it, a more accurate bug summary might be "always couple category links with the page content." Currently, the text input area can interrupt the page content and the categories (as described in comment 7) when previewing a page. This should be fixed in Monobook and in any other core skins where it's an issue.

Thanks for cross-reference Gerrit change #47212. :-)
Comment 18 Shikha Shree 2014-02-17 14:22:23 UTC
I am new to FOSS and mediawiki how do I start on this bug and how do I replicate the error on my local machine.
Comment 19 Bartosz Dziewoński 2014-02-17 17:23:51 UTC
This feature request already has a patch pending review.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links