Last modified: 2011-12-02 09:44:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28743, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26743 - Show preview without javascript results in thread and edit form not showing if it has been bumped since you clicked reply
Show preview without javascript results in thread and edit form not showing i...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-15 11:27 UTC by Nikola Kovacs
Modified: 2011-12-02 09:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nikola Kovacs 2011-01-15 11:27:47 UTC
Here are the steps to reproduce this bug, bear with me:

1. Disable javascript
2. Open a talk page in two tabs in your browser.
3. Click "reply" on the same comment in both tabs
4. Type something in both tabs
5. In one tab, click save page, wait for the comment to be saved. Make sure you bump the thread.
6. In the other tab, click show preview.

After this, the thread you were replying to will not be shown (including the edit form), which means you just lost your comment.

I've tracked down the bug to LqtDiscussionPager::getRows(). The problem is that this function calls a mysql query that selects all root threads where thread_sortkey<offset, where offset is the timestamp of the latest comment when you clicked reply. However, since the thread has since been bumped, the root comment now has a sortkey larger than this timestamp, so it won't be selected.
Comment 1 Nikola Kovacs 2011-02-25 08:17:04 UTC
This also causes threads to disappear when you click on a link in Recent Changes if the thread has been bumped since you loaded Recent Changes, because the links in RC also have an offset parameter.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links