Last modified: 2011-01-15 15:51:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28724, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26724 - TalkHere throws a fatal error when $wgMaxCredits in not 0
TalkHere throws a fatal error when $wgMaxCredits in not 0
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-14 10:36 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2011-01-15 15:51 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alexandre Emsenhuber [IAlex] 2011-01-14 10:36:09 UTC
When using TalkHere extension with $wgMaxCredits different than 0, the following error happens:

Catchable fatal error: Argument 1 passed to Credits::getCredits() must be an instance of Article, instance of TalkHereArticle given, called in includes/SkinTemplate.php on line 386 and defined in includes/Credits.php on line 59
Comment 1 Daniel Kinzler 2011-01-14 10:55:00 UTC
What the hell is Credits?

Anyway, I suppose it'S a bug in Credits, not TalkHere: From what I gether, Credits::getCredits() checks that the argument is an instance of Article, instead of checking if it's an *compatible* with the Article class. It should use instanceof instead getclass.

I can't do much about it from my side, so i'm assigning it back to the ML.
Comment 2 Alexandre Emsenhuber [IAlex] 2011-01-15 15:51:10 UTC
Fixed in r80403 and r80404.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links