Last modified: 2011-01-14 16:17:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28721, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26721 - Subtitle lines should be broken more evenly
Subtitle lines should be broken more evenly
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Timed text (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-14 05:38 UTC by Amir E. Aharoni
Modified: 2011-01-14 16:17 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2011-01-14 05:38:45 UTC
Currently a subtitle line is broken when it is too long to fit in the video frame. This way, if the line has 12 words and only 10 fit in the frame, the top displayed line will have 10 and the bottom line will have 2.

The subtitles should be broken more evenly, so that line lengths will be more or less equal. As much as possible, character count, word count and actual line length should be taken into account. This will make the subtitles much easier to read.
Comment 1 Michael Dale 2011-01-14 16:17:14 UTC
this is kind of tricky problem to solve perfectly via an algorithm, we can relatively easily evenly divide words pre line, but that is not always the ideal breaking point. Sometimes its a coma or end of thought. 

What we can do is allow users to include line breaks newlines in the subtitle wikitext so they decide when the line breaks rather than the word count. This lets you break on commas or end of more logical breaking points.  

The subtitle parser was not handling <br> very well so that is fixed in r80276
you can see an example here ( once I push out the update ) 
http://commons.wikimedia.org/wiki/File:Folgers.ogv#t=13
where we break after the comma.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links