Last modified: 2012-02-10 19:22:31 UTC
I created a thread here: http://liquidthreads.labs.wikimedia.org/wiki/Thread:Talk:LiquidThreads_testing/Deletion_test I replied and deleted the reply, then I replied again. Both my replies were named "Thread:Talk:LiquidThreads_testing/Deletion_test/reply" and as a result their edit history is now merged. If you go to http://liquidthreads.labs.wikimedia.org/w/index.php?title=Thread:Talk:LiquidThreads_testing/Deletion_test/reply&action=history and you are a sysop, you'll see that there's a deleted revision. Attempting to restore the deleted revision causes a database error in function "Thread::save/Thread::commitRevision/Thread::undelete": "1062: Duplicate entry '3527' for key 2 (10.0.6.27)". However, even if this were fixed, you would not be able to properly restore a deleted reply once another reply has taken its place. LQT would need to take into account deleted replies when it comes up with the automatic titles for comments to avoid merging them like this.
Created attachment 7995 [details] proposed patch This simple patch to Threads::incrementedTitle also checks deleted replies when trying to determine a title for a new thread. I haven't done any extensive testing, but in theory it shouldn't break anything, since it's equivalent to first adding a new reply then deleting the existing one instead of the other way around.
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Thanks a lot for the patch, Nikola. I appreciate your help. I've applied it in r111182. Marking RESOLVED FIXED.
