Last modified: 2011-08-19 19:12:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28621, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26621 - WikiEditor: Icons for dialogs in wrong order
WikiEditor: Icons for dialogs in wrong order
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://prototype.wikimedia.org/d-en/i...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-07 10:09 UTC by Michael M.
Modified: 2011-08-19 19:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2011-01-07 10:09:32 UTC
In MW 1.17 the icons for dialogs in the toolbar are displayed in wrong order, the reference icon appears on discussion pages as well. See URL.
It should be: link - file - signature
It is: file - signature - link - reference
This is obvious due to r74114.
Comment 1 Roan Kattouw 2011-01-07 21:09:27 UTC
Fixed the reference button to no longer appear in talk namespaces in r79842. I asked Trevor to comment on the order issue.
Comment 2 Trevor Parscal 2011-01-07 21:39:21 UTC
I think the order should match user expectations (justification for change the order back to how it was), but also take into consideration information we have about how often the tools are used (need to dig up click tracking stats) because we know that users most commonly look at the icons in order, looking for what they want. Anyone have the click tracking stats?
Comment 3 Trevor Parscal 2011-01-10 23:05:32 UTC
I talked to Parul about this, and the order for the discussion page should be (from left to right): link, file, signature. This is based in both qualitative and quantitative user behavior observation.

I also looked into why this is occuring, and as Roan mentioned, it's because we now use the API to remove the 2 link tools (internal and external) and add the link dialog tool - which results in the link tool being at the very end.

There's not elegant way to control order or placement right now - I'm open to ideas.
Comment 4 Michael M. 2011-01-11 08:40:43 UTC
What about removing file, signature and redirect in ext.wikiEditor.dialogs.js and adding them again in the right place? The config object should be stored somewhere for this purpose (there is already a FIXME in ext.wikiEditor.toolbar.js for this), but that shouldn't be too hard.
Comment 5 Bugmeister Bot 2011-08-19 19:12:56 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links