Last modified: 2012-04-16 09:15:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28620, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26620 - insertTags fails on Special:Upload when jquery is enabled
insertTags fails on Special:Upload when jquery is enabled
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-07 10:08 UTC by Nikola Kovacs
Modified: 2012-04-16 09:15 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nikola Kovacs 2011-01-07 10:08:39 UTC
edit.js has the following line at the beginning of function insertTags:

if ( typeof $j != 'undefined' && typeof $j.fn.textSelection != 'undefined' &&
			( currentFocused.nodeName.toLowerCase() == 'iframe' || currentFocused.id == 'wpTextbox1' ) ) {

however, on Special:Upload, currentFocused will be null, and this will fail when $j is not undefined. If $j is undefined, it will skip that condition and jump to the next part that correctly finds the upload description textarea, and everything will work.

This line should be changed to:

if ( typeof $j != 'undefined' && typeof $j.fn.textSelection != 'undefined' &&
			( currentFocused && (currentFocused.nodeName.toLowerCase() == 'iframe' || currentFocused.id == 'wpTextbox1' ) ) ) {
Comment 1 Roan Kattouw 2011-01-08 16:17:54 UTC
Fixed in r79865, fix deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links