Last modified: 2011-01-07 21:57:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28619, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26619 - CodeReview loses space at the beginning of the comment
CodeReview loses space at the beginning of the comment
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-07 09:41 UTC by Niklas Laxström
Modified: 2011-01-07 21:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2011-01-07 09:41:45 UTC
It's been messing up many of my comments by showing the preformatted text as plain text in the first line. Interestingly this does not show up in preview.
Comment 1 Sam Reed (reedy) 2011-01-07 15:30:44 UTC
I've got a feeling I added this for some request before...

Will have a look later...
Comment 2 Sam Reed (reedy) 2011-01-07 18:18:58 UTC
bug 25101 and r72626

/me shrugs
Comment 3 Brion Vibber 2011-01-07 21:50:26 UTC
Switching from trim() to rtrim() should do it -- it's save to remove trailing whitespace, but leading whitespace is syntactically significant.
Comment 4 Sam Reed (reedy) 2011-01-07 21:57:02 UTC
r79844

Also rtrim comment previews in that revision also (so preview and saving comments has the same affect

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links