Last modified: 2011-01-09 15:54:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28609, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26609 - Accept rtsp links for URL-type properties
Accept rtsp links for URL-type properties
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-06 15:22 UTC by Florian Dufour
Modified: 2011-01-09 15:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (617 bytes, patch)
2011-01-06 15:22 UTC, Florian Dufour
Details

Description Florian Dufour 2011-01-06 15:22:07 UTC
Created attachment 7957 [details]
Patch

Hi,

Would it be possible to accept "rtsp://..." URLs for URL-type properties ? As for now, we can just use http, https and ftp URLs.

A patch is attached.
Comment 1 Yaron Koren 2011-01-06 16:40:25 UTC
Hi,

Thanks for the patch; this has now been added to Semantic Forms, in SVN.
Comment 2 Bawolff (Brian Wolff) 2011-01-06 22:18:07 UTC
Stupid question (coming from someone who doesn't know anything about semantic forms), but wouldn't you want this to be consistent with what mediawiki is configured to consider to be a URL? Mediawiki even outputs a wgUrlProtocols js variable for that purpose.
Comment 3 Yaron Koren 2011-01-07 16:55:25 UTC
Bawolff - that's a reasonable suggestion, although I'm not sure that the set of allowed prefixes for MediaWiki and the set of allowed prefixes for Semantic MediaWiki will always be the same. For instance, MediaWiki treats "mailto:" URLs as standard URLs, while I don't know if SMW does, or should (there's a separate data type for email addresses). I'm adding Markus as a CC - Markus, do you have any thoughts on the matter?
Comment 4 Markus Krötzsch 2011-01-09 15:54:20 UTC
SMW has only very little restrictions on the URIs that can be used. If a URI used in SMW is not using one of MediaWiki's supported protocols then this simply means that SMW will not print it in [ ] (since this only works properly if the protocol is allowed in MW). But the value is accepted in any case, so there is no need to worry about SMW here. If URI validation was to be extended, then SMW would add more checks for allowed URL structures and characters but not restrict the protocol.

The purpose of Type:Email mainly is to make the mailto optional whereas proper URLs must always specify a protocol explicitly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links