Last modified: 2011-01-11 22:40:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28576, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26576 - OpenStackManager extension needs proper security checks
OpenStackManager extension needs proper security checks
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenStackManager (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Ryan Lane
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-05 16:45 UTC by Ryan Lane
Modified: 2011-01-11 22:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Lane 2011-01-05 16:45:08 UTC 
There's a few rudimentary security checks in place now, but the extension needs to ensure users have proper rights to access certain special pages.

Specifically, Special:NovaProject, and Special:NovaDomain should ensure a user is an admin, or have some special right.

Additionally, the current security checks aren't likely done in the normal MediaWiki style. This should be corrected.
Comment 1 Ryan Lane 2011-01-07 06:17:53 UTC 
Accidentally marked this as resolved.
Comment 2 Ryan Lane 2011-01-11 20:40:24 UTC 
More specific implementation:

Special:NovaProject should be limited to wiki admins

Special:NovaDomain, Special:NovaHost, and Special:NovaAddress should be limited to users with the 'netadmins' role.

Special:NovaInstance should be limited to users with the 'sysadmin' role.

Roles are pulled from LDAP, and are accessible via OpenStackNovaUser->inRole(), or OpenStackNovaUser->getRoles()
Comment 3 Ryan Lane 2011-01-11 22:40:23 UTC 
Resolved in r80047.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links