Last modified: 2014-09-02 16:52:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28547, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26547 - ignore "display:none;" inside displaytitle
ignore "display:none;" inside displaytitle
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-02 15:34 UTC by Umherirrender
Modified: 2014-09-02 16:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2011-01-02 15:34:45 UTC
Using "display:none;" inside displaytitle (for the full or for parts) makes it hard to copy and using as the page title for wikilinks. That break the intention of displaytitle (if $wgRestrictDisplayTitle is true).

It is possible to ignore <(div|span) style="display:none;"></(div|span)> when parsing displaytitle?

Thanks.
Comment 1 X! 2011-01-26 03:26:17 UTC
It'd probably be a good idea just to ignore all divs/spans... people could also do something like "position:absolute;" and all sorts of other hacks like that... Just ignore all divs/spans to get rid of this displaytitle abuse anyway.
Comment 2 Krinkle 2011-01-26 10:49:48 UTC
if $wgRestrictDisplayTitle is true afaik the display title can only be something that is sanatized to the same as the real title of the article.

If it's off it can be anything, and many wikis use it to give certain pages or a category of pages certain background/font-colors, using templates like:

{{DISPLAYTITLE:<small>something: </smal><span whatever>{{SUBPAGENAME}}</span>}}
Comment 3 bluehairedlawyer 2011-09-22 21:25:54 UTC
I've upgraded this bug from enhancement to normal, as the existence of the bug allows editors to override the rule established by $wgRestrictDisplayTitle and break the rule that a copied and pasted page title should link to the it was copied from.
Comment 4 Daniel Friesen 2011-09-22 21:37:40 UTC
What ever happened to the plan of including the proper title in a subtitle for any display title that didn't normalize back to the title?
Comment 5 Umherirrender 2011-10-07 19:48:27 UTC
(In reply to comment #4)
> What ever happened to the plan of including the proper title in a subtitle for
> any display title that didn't normalize back to the title?

Please open a bug for that, if you want that. Thanks.
Comment 6 Bartosz Dziewoński 2013-05-22 08:04:36 UTC
Still valid. We already strip some inline CSS, this shouldn't be that hard to do.
Comment 7 Gerrit Notification Bot 2013-05-22 08:59:40 UTC
Related URL: https://gerrit.wikimedia.org/r/64911 (Gerrit Change Ie162535b6bcbebce4ee69f6dcc1957ccccc3c672)
Comment 8 Daniel Friesen 2013-05-22 11:58:54 UTC
Side note, that tag blacklist is out of date from what I rebember.
Comment 9 Bartosz Dziewoński 2013-05-24 21:23:42 UTC
Merged.
Comment 10 Andre Klapper 2013-06-03 08:51:05 UTC
Related regression: bug 49015

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links