Last modified: 2014-02-24 21:53:09 UTC
In /monobook/main.css, the following CSS for soft redirects is in place, but this has been completely overlooked in Vector, resulting in too small links: /* Soft redirect */ .redirectText { font-size: 150%; margin: 5px; }
Created attachment 8552 [details] Patch file for trunk/phase3/skins/vector/screen.css
Trevor: Was this a design/usability choise (having .redirectText not be small, too many font-size variations on a page, perhaps potentially unreadable) or was it forgotten and is it now too big in Vector / attracting too much attention maybe ? I can see logic in both.
The links are now too *small* in Vector, making them easy to overlook (IMO). I did 'fix' it in enwiki's vector.css, so they show correct there.
http://en.wikipedia.org/wiki/Foo?redirect=no&useskin=monobook http://en.wikipedia.org/wiki/Foo?redirect=no&useskin=vector They look fine to me either way. INVALID?
(In reply to comment #4) > They look fine to me either way. INVALID? Umm... (In reply to comment #3) > The links are now too *small* in Vector, making them easy to overlook (IMO). I > did 'fix' it in enwiki's vector.css, so they show correct there. Maybe because of this ;-)
Grrrr... hiding a bug and then not providing descriptions or screenshots for anybody to test doesn't help. :) Here's another site: http://fr.wikipedia.org/wiki/Foo?redirect=no&useskin=vector http://fr.wikipedia.org/wiki/Foo?redirect=no&useskin=monobook Vector is visibly smaller here -- the exact same size as body text -- whereas MonoBook bumps the font size up a bit. Still not particularly bad either way; the smaller font size seems a smidge too small maybe but the larger one is a smidge too large IMO.
"Neutral" environment: http://www.mediawiki.org/w/index.php?title=Sandbox2&redirect=no&useskin=vector http://www.mediawiki.org/w/index.php?title=Sandbox2&redirect=no&useskin=monobook
The 150% in Monobook is the size of H2 headers, which matches with the arrow symbol size. I tried a H3 equevalent, which is 132% (and bolded), but I found that a little too small and bold. I want to fix the alignment anyway by adding the following rule to the patch: div.redirectMsg img { vertical-align: text-bottom; } So once we agree on the size, I'll update the patch.
I agree with Brion that 150% is a bit over the top; I went with 140% in r91831
Created attachment 8768 [details] Patch for monobook/screen.css Two thing: 140% does not match with the arrow symbol, and you left out the 5px margin, making the text stick too close to the image. Brion also said there was nothing wrong with 150%. So please don't make unilateral changes to the patch. I've attached a new patch.
Created attachment 8769 [details] Patch for monobook/screen.css Fix patch file.
(In reply to comment #10) > and you left out the 5px margin, making the text stick too close to the image. The arrow leads from the article title to the redirect text. It's not an arrow standing besides unrelated text, where separation would be useful. ( at least use margin-left, since this it what you want to change) >Brion also said there was nothing wrong with 150%. Comment #6: > the smaller font size seems a smidge too small maybe but the larger one is a > smidge too large IMO.
I just followed the monobook desing; it has a 5px margin on all sides to seperate *any* text from the arrow (yes, there can be other text on a redirect page).
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment on attachment 8769 [details] Patch for monobook/screen.css Patch no longer applies to trunk, so marking obsolete (checked by Rusty per http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html ).
Erwin, if you'd like to revise your patch to work with the current codebase, that would be welcome; if you'd like suggestions or discussion, please chat with other MediaWiki developers in #mediawiki on Freenode IRC. Thanks!
Created attachment 9508 [details] Patch for vector/screen.css Fontsize 150%, margin 5px. The img align was already in trunk. (I also misnamed the previous patch, it was of course ment for Vector.)
Thanks for the patch, Erwin. Added the "patch" & "need-review" keywords to indicate that your new patch awaits code review.
Erwin, I'm sorry for the wait. Your patch will get reviewed faster if you submit it as a Git branch via Gerrit - https://www.mediawiki.org/wiki/Developer_access . Thanks.
To get this going I'd recommend anybody interestedh here to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial
Patch needs update again (plus http://tools.wmflabs.org/gerrit-patch-uploader/ might be able to work around any Gerrit reluctance): This is now in https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/skins%2Fvector%2Fcomponents%2Fcommon.less#L70 : .redirectText { font-size: 140%; }
That will be sufficient. No new patch needed. Closing this.
No fix involved, closing as WORKSFORME.
